Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0][wasm] Use latest sdk 7.0 sdk for workload testing, and perf runs #82219

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

radical
Copy link
Member

@radical radical commented Feb 16, 2023

Fixes 7.0 perf runs:

Traceback (most recent call last):
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 373, in <module>
    __main(sys.argv[1:])
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 318, in __main
    dotnet_version = dotnet.get_dotnet_version(target_framework_moniker, args.cli) if args.dotnet_versions == [] else args.dotnet_versions[0]
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 549, in get_dotnet_version
    sdk_path = get_sdk_path(dotnet_path) if sdk_path is None else sdk_path
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 533, in get_sdk_path
    base_path = get_base_path(dotnet_path)
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 527, in get_base_path
    'Did not find "Base Path:" entry on the `dotnet --info` command'
RuntimeError: Did not find "Base Path:" entry on the `dotnet --info` command

@radical radical added arch-wasm WebAssembly architecture area-Infrastructure-mono perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines labels Feb 16, 2023
@ghost ghost assigned radical Feb 16, 2023
@ghost
Copy link

ghost commented Feb 16, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes 7.0 perf runs:

Traceback (most recent call last):
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 373, in <module>
    __main(sys.argv[1:])
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 318, in __main
    dotnet_version = dotnet.get_dotnet_version(target_framework_moniker, args.cli) if args.dotnet_versions == [] else args.dotnet_versions[0]
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 549, in get_dotnet_version
    sdk_path = get_sdk_path(dotnet_path) if sdk_path is None else sdk_path
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 533, in get_sdk_path
    base_path = get_base_path(dotnet_path)
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 527, in get_base_path
    'Did not find "Base Path:" entry on the `dotnet --info` command'
RuntimeError: Did not find "Base Path:" entry on the `dotnet --info` command
Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono, perf-pipeline

Milestone: -

@radical radical changed the title [wasm] Use latest sdk 7.0 sdk for workload testing, and perf runs [release/7.0][wasm] Use latest sdk 7.0 sdk for workload testing, and perf runs Feb 16, 2023
Fixes 7.0 perf runs:

```
Traceback (most recent call last):
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 373, in <module>
    __main(sys.argv[1:])
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 318, in __main
    dotnet_version = dotnet.get_dotnet_version(target_framework_moniker, args.cli) if args.dotnet_versions == [] else args.dotnet_versions[0]
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 549, in get_dotnet_version
    sdk_path = get_sdk_path(dotnet_path) if sdk_path is None else sdk_path
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 533, in get_sdk_path
    base_path = get_base_path(dotnet_path)
  File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 527, in get_base_path
    'Did not find "Base Path:" entry on the `dotnet --info` command'
RuntimeError: Did not find "Base Path:" entry on the `dotnet --info` command
```
@radical radical marked this pull request as ready for review March 7, 2023 21:06
@radical
Copy link
Member Author

radical commented Mar 7, 2023

Waiting for dotnet-runtime-perf build 20230307.5.

@radical
Copy link
Member Author

radical commented Mar 8, 2023

Waiting for dotnet-runtime-perf build 20230307.5.

This ran successfully except for one failure which was unrelated - build process exited with code 139.

@carlossanlop we want to merge this whenever the branch will be open for it.

@carlossanlop carlossanlop merged commit 60d5c56 into dotnet:release/7.0 Mar 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants